Request.Cookies should not have the same class as Result.Cookies

[mariussoutier]

Request cookies and response cookies are implemented using the same class, play.api.mvc.Cookie. So the following would compile:

Ok.withCookies(request.cookies:_*)

However it would set all request cookies to HTTP-only and remove all other settings.

So there should be two different Cookie classes, RequestCookie(name, value), and Cookie should be renamed to ResponseCookie (or SetCookie).

[mariussoutier]

This is what I currently use to avoid the issue:

/**
  * Encapsulates a cookie that is coming from the client with a request and only contains the name and value,
  * nothing else.
  */
case class RequestCookie(name: String, value: String)

object RequestCookie {
  def fromPlayCookie(cookie: play.api.mvc.Cookie): RequestCookie =
    RequestCookie(cookie.name, cookie.value)

  /** Decode request cookies from a cookie header */
  def decodeCookieHeader(header: String): Seq[RequestCookie] =
    play.api.mvc.Cookies.decodeCookieHeader(header).map(fromPlayCookie)
}