Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore sbt classloader settings #8206

Open
TimMoore opened this issue Feb 1, 2018 · 1 comment
Open

Restore sbt classloader settings #8206

TimMoore opened this issue Feb 1, 2018 · 1 comment

Comments

@TimMoore
Copy link

TimMoore commented Feb 1, 2018

#7288 removed some settings from the sbt plugin that allowed for customization of the classloaders used in development mode. These appeared to be unused, but are actually useful for adding dynamic instrumentation of classes via extensions to the Play sbt plugin.

As noted in the Lightbend Telemetry documentation, the instrumentation provided by Cinnamon does not work correctly when running Play apps in development mode because of its reliance on a Java agent. If the classloader hooks are restored, this could be an alternative approach for instrumenting the framework classes. These same hooks could be used by third-parties for similar purposes.

We'll want this capability in Lagom as well. Ideally, it could inherit it from Play.

@TimMoore
Copy link
Author

TimMoore commented Feb 1, 2018

#7773 might be an alternative option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants