Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract chapter name from hash #44

Merged
merged 2 commits into from Sep 19, 2016
Merged

Extract chapter name from hash #44

merged 2 commits into from Sep 19, 2016

Conversation

pietbrauer
Copy link
Member

I introduced a bug yesterday, which led to chapter names not being extracted from the hash resulting in chapter names in the Manifest.plist being "{\"name\"=>\"test_chapter\"}.playgroundchapter" instead of test_chapter.plagroundchapter.

@pietbrauer
Copy link
Member Author

Please don't merge yet.

@pietbrauer pietbrauer closed this Sep 18, 2016
@pietbrauer pietbrauer reopened this Sep 18, 2016
@pietbrauer
Copy link
Member Author

ashfurrow
ashfurrow approved these changes Sep 18, 2016
View reviewed changes
Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when you're ready. Thanks again!

@pietbrauer pietbrauer merged commit ceb8169 into playgroundbooks:master Sep 19, 2016
@pietbrauer pietbrauer deleted the fix-messed-up-chapter-names branch September 19, 2016 09:15
@orta
Copy link
Collaborator

orta commented Sep 20, 2016

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfurrow ashfurrow ashfurrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pietbrauer @orta @ashfurrow