Removes extraneous newlines. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rpowelll Are you available to look this over? No worries at all, I know you're busy! |
| # - Extraneous newlines before /*: | ||
| # - Extraneous newlines after */ | ||
| # - Extraneous newlines either before or after //: | ||
| page_contents |
There was a problem hiding this comment.
Maybe break this out into a strip_extraneous_newlines method to make it more explicit, since this main process_page method will likely grow to have more responsibilities eventually.
|
It might be a good idea to add a test to ensure we're not stripping newlines from inside comment blocks as well since in Markdown those can be syntactically significant. My general rule is to over-test any time you use regular expressions since they tend to be fragile and introduce regressions. |
|
That's a good idea! |
|
👍 looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20.
Regexes gave me trouble for stripping lines like
I originally used
squeeze("\n")but that strips consecutive newlines in code, which is not good (I added a test for that). So my solution was tosplitbased on a regex that used\n*and thenjoin. The problem is that this adds a newline before any matched components, so I make sure to remove newlines preceding//:comments after that check. Let me know what you think, I'm sure there's a better solution.