Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t default to edge to edge live views #36

Merged
merged 1 commit into from
Sep 17, 2016
Merged

Don’t default to edge to edge live views #36

merged 1 commit into from
Sep 17, 2016

Conversation

pietbrauer
Copy link
Member

@pietbrauer pietbrauer commented Sep 17, 2016

I encountered a bug which led to the live view being scaled up quite a bit.

Before change:

img_0411

After change:

img_0410

Ideally this would be customisable in the book.yaml but I wasn't sure on how to achieve this as the chapters are currently [String] and should become [String: String]:

Before:

chapters:
  - "Chapter 1"
  - "Chapter 2"

After:_

chapters:
  - name: "Chapter 1"
     EdgeToEdgeLiveView: true
  - name: "Chapter 2"
     EdgeToEdgeLiveView: false

Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ashfurrow
Copy link
Member

Good question, I like the idea. Want to open an issue to discuss the yams format?

@ashfurrow ashfurrow merged commit 3d808dd into playgroundbooks:master Sep 17, 2016
@pietbrauer pietbrauer deleted the add-live-view-customisation-support branch September 17, 2016 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants