Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper initial messages for pre-releases #29

Closed
playpauseandstop opened this issue Nov 6, 2020 · 0 comments · Fixed by #30
Closed

Proper initial messages for pre-releases #29

playpauseandstop opened this issue Nov 6, 2020 · 0 comments · Fixed by #30
Assignees
@playpauseandstop
Labels
bug Something isn’t working
Milestone
20.1.0

Comments

@playpauseandstop
Copy link
Owner

When repository does not contain tags and pyproject.toml or package.json contains pre-release version, need to put "Initial pre-release" into changelog file, even no --pre flag is passed.

Right now badabump puts proper pre-release note into changelog file only when --pre flag is passed.

Relates: #15
@playpauseandstop playpauseandstop added the fix A bug fix label Nov 6, 2020
@playpauseandstop playpauseandstop added this to the 20.1.0 milestone Nov 6, 2020
@playpauseandstop playpauseandstop self-assigned this Nov 6, 2020
@playpauseandstop playpauseandstop added bug Something isn’t working and removed fix A bug fix labels Nov 6, 2020
playpauseandstop added a commit that referenced this issue Nov 6, 2020
@playpauseandstop
fix: Properly understand initial pre-release version
193d6d8 
Ensure, when there is no tags available, properly understands
pre-release version from `pyproject.toml` or `package.json`.

And if pre-release version provided there put proper message into the
changelog file.

Fixes: #29
playpauseandstop added a commit that referenced this issue Nov 6, 2020
@playpauseandstop
fix: Properly understand initial pre-release version
125e407 
Ensure, when there is no tags available, properly understands
pre-release version from `pyproject.toml` or `package.json`.

And if pre-release version provided there put proper message into the
changelog file.

Fixes: #29
Issue: #28
@playpauseandstop playpauseandstop mentioned this issue Nov 6, 2020
Merged
playpauseandstop added a commit that referenced this issue Nov 6, 2020
@playpauseandstop
fix: Properly understand initial pre-release version (#30)
1861b94 
Ensure, when there is no tags available, properly understands
pre-release version from `pyproject.toml` or `package.json`.

And if pre-release version provided there put proper message into the
changelog file.

Fixes: #29
Issue: #28
badabump-release-bot bot pushed a commit that referenced this issue Nov 6, 2020
@playpauseandstop
chore: 20.1.0rc1 Release
ff0945c 
Fixes:
------

- [#29, #28] Properly understand initial pre-release version (#30)
@badabump-release-bot badabump-release-bot bot mentioned this issue Nov 6, 2020
Merged
playpauseandstop added a commit that referenced this issue Nov 6, 2020
@badabump-release-bot @playpauseandstop
chore: 20.1.0rc1 Release (#31)
39cbc13 
Fixes:
------

- [#29, #28] Properly understand initial pre-release version (#30)

Co-authored-by: playpauseandstop <playpauseandstop@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@playpauseandstop playpauseandstop

Labels
bug Something isn’t working
Projects
None yet
Milestone
20.1.0
Development

Successfully merging a pull request may close this issue.

fix: Properly understand initial pre-release version playpauseandstop/badabump
1 participant
@playpauseandstop