fix(valid-describe-callback): False positive with `test.describe.conf…

…igure`
playwright-community · Feb 27, 2024 · 91988d5 · 91988d5
1 parent b325718
commit 91988d5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/rules/valid-describe-callback.test.ts b/src/rules/valid-describe-callback.test.ts
@@ -158,6 +158,10 @@ runRuleTester('valid-describe-callback', rule, {
     },
   ],
   valid: [
+    'describe.configure({ timeout: 600_000 })',
+    'describe("foo", function() {})',
+    'describe("foo", () => {})',
+    'test.describe.configure({ timeout: 600_000 })',
     'test.describe("foo", function() {})',
     'test.describe("foo", () => {})',
     'test.describe(`foo`, () => {})',

diff --git a/src/rules/valid-describe-callback.ts b/src/rules/valid-describe-callback.ts
@@ -22,6 +22,11 @@ export default {
         const call = parseFnCall(context, node);
         if (call?.group !== 'describe') return;
 
+        // Ignore `describe.configure()` calls
+        if (call.members.some((s) => getStringValue(s) === 'configure')) {
+          return;
+        }
+
         if (node.arguments.length < 1) {
           return context.report({
             loc: node.loc!,