fix(prefer-web-first-assertions): Fix error with nested call expressions

Fixes #276
playwright-community · Mar 20, 2024 · bf821f5 · bf821f5
1 parent ae78045
commit bf821f5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/rules/prefer-web-first-assertions.test.ts b/src/rules/prefer-web-first-assertions.test.ts
@@ -1,3 +1,4 @@
+import dedent from 'dedent'
 import rule from '../../src/rules/prefer-web-first-assertions'
 import { runRuleTester, test } from '../utils/rule-tester'
 
@@ -708,6 +709,17 @@ runRuleTester('prefer-web-first-assertions', rule, {
     { code: test('let visible = await foo.isVisible()') },
     { code: test('const value = await bar["inputValue"]()') },
     { code: test('const isEditable = await baz[`isEditable`]()') },
+    {
+      code: dedent`
+        import { expect } from '@playwright/test';
+
+        test('my test', async ({ page }) => {
+          await expect
+            .poll(() => foo, { message })
+            .toEqual(expect.objectContaining({ bar: expect.anything() }));
+        });
+      `,
+    },
     // Global aliases
     {
       code: test('await assert(page.locator(".tweet")).toBeVisible()'),

diff --git a/src/rules/prefer-web-first-assertions.ts b/src/rules/prefer-web-first-assertions.ts
@@ -62,8 +62,8 @@ const supportedMatchers = new Set([
  * If the expect call argument is a variable reference, finds the variable
  * initializer.
  */
-function dereference(context: Rule.RuleContext, node: ESTree.Node) {
-  if (node.type !== 'Identifier') {
+function dereference(context: Rule.RuleContext, node: ESTree.Node | undefined) {
+  if (node?.type !== 'Identifier') {
     return node
   }