Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update iframe tests #115

Merged
merged 10 commits into from
Jul 1, 2021
Merged

Update iframe tests #115

merged 10 commits into from
Jul 1, 2021

Conversation

mskelton
Copy link
Member

@mskelton mskelton commented Jul 1, 2021

Fixes #104

This updates our iframe tests to have our own testing page so we have better control over the tests and aren't subjected to the whims of the sites we are currently depending on.

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #115 (17989d4) into master (437f3ec) will not change coverage.
The diff coverage is n/a.

❗ Current head 17989d4 differs from pull request most recent head 21c2aca. Consider uploading reports for the commit 21c2aca to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #115   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files          18       18           
  Lines         222      222           
  Branches       20       20           
=======================================
  Hits          220      220           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437f3ec...21c2aca. Read the comment docs.

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome!

config/global-setup.js Outdated Show resolved Hide resolved
@mskelton mskelton requested a review from mxschmitt July 1, 2021 21:04
@mskelton mskelton merged commit 8cce4b3 into master Jul 1, 2021
@mskelton mskelton deleted the mskelton/issue104 branch July 1, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make test site for iframe tests
3 participants