fix: export matchers from package #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 90.97% 90.97%
=======================================
Files 10 10
Lines 144 144
Branches 26 26
=======================================
Hits 131 131
Misses 13 13 Continue to review full report at Codecov.
|
mskelton
approved these changes
Jun 9, 2021
| @@ -96,3 +96,5 @@ declare global { | |||
| interface Matchers<R> extends PlaywrightMatchers<R> {} | |||
| } | |||
| } | |||
|
|
|||
| export const matchers: any | |||
There was a problem hiding this comment.
Suggested change
| export const matchers: any | |
| export const matchers: jest.ExpectExtendMap |
This is the type extend.expect uses, so we could probably make this a bit stronger.
There was a problem hiding this comment.
When using it with Playwright, there is no Jest I think and expect.extend accepts any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I had the fix already locally)
fixes #82