Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow iframe handle as arg to toEqualText and toEqualUrl #86

Merged
merged 5 commits into from
Jun 19, 2021

Conversation

mskelton
Copy link
Member

Fixes #85

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021

Codecov Report

Merging #86 (96895c4) into master (ef09ed8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 96895c4 differs from pull request most recent head 5d0dd82. Consider uploading reports for the commit 5d0dd82 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files          11       11           
  Lines         155      155           
  Branches       27       26    -1     
=======================================
  Hits          142      142           
  Misses         13       13           
Impacted Files Coverage Δ
src/matchers/toEqualUrl/index.ts 100.00% <100.00%> (ø)
src/matchers/utils.ts 98.14% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef09ed8...5d0dd82. Read the comment docs.

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work

@mxschmitt mxschmitt merged commit cfaee10 into master Jun 19, 2021
@mxschmitt mxschmitt deleted the mskelton/issue85 branch June 19, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expect() should accept Frame argument.
3 participants