Fixes to check browsers for parallel

playwright-community · Mar 18, 2020 · c0109ab · c0109ab
1 parent 7228fab
commit c0109ab
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/bin/testProcess.ts b/src/bin/testProcess.ts
@@ -60,11 +60,14 @@ const exec = ({
 
 const runner = async (sequence: string, params: string[]): Promise<void> => {
   // TODO Work only if we pass config through package.json
-  const rootDir = process.env.npm_package_jest_rootDir
-    ? `${process.cwd()}/${process.env.npm_package_jest_rootDir}/`
-    : process.cwd()
+  const rootDir = `${process.cwd()}/${process.env.npm_package_jest_rootDir ||
+    ''}/`
   const config = await readConfig(rootDir)
-  const { browsers = [], devices = [] } = config
+  const { devices = [] } = config
+  let browsers = config.browsers
+  if (!browsers) {
+    browsers = browser ? [browser] : []
+  }
   let exitCodes: (number | null)[] = []
   checkCommand(browsers, devices)
   if (!browsers.length && devices.length) {

diff --git a/types/global.d.ts b/types/global.d.ts
@@ -1,4 +1,5 @@
-import { Page, Browser, BrowserContext } from 'playwright-core'
+import { Page, BrowserContext } from 'playwright-core'
+import { BrowserType } from '../src/constants'
 
 interface JestPlaywright {
   /**
@@ -17,7 +18,7 @@ interface JestPlaywright {
 
 declare global {
   const page: Page
-  const browser: Browser
+  const browser: BrowserType
   const context: BrowserContext
   const jestPlaywright: JestPlaywright
 }