Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork jest-dev-server? #104

Closed
thernstig opened this issue Apr 9, 2020 · 16 comments
Closed

Fork jest-dev-server? #104

thernstig opened this issue Apr 9, 2020 · 16 comments

Comments

@thernstig
Copy link
Contributor

thernstig commented Apr 9, 2020

Hi!

Is there a chance to fork the jest-dev-server into this repo or a separate repo? I just submitted two new issues on jest-dev-server (see argos-ci/jest-puppeteer#341 and argos-ci/jest-puppeteer#342) but the overall repo (https://github.com/smooth-code/jest-puppeteer/commits/master) seems a bit stale, 5 commits in soon 4 months.

Another idea would be to put jest-playwright and all its packages under an organisation instead of under mmarkelov/jest-playwright. E.g. jest-playwright/X or something, so you could bring more packages under there?

I am aware I am going out of my way here for asking for something where you are already donating a great deal of your free time. Which is very much appreciated.

@mmarkelov
Copy link
Member

@thernstig thank you for your feedback as always)
Put jest-playwright under organization may be a good idea, we can also put @mxschmitt packages there. @mxschmitt what do you think about it?

@thernstig
Copy link
Contributor Author

Yes, I've read lots of good about putting it all in one org. It gives a sense of quality for a project, making it more official.

@mxschmitt
Copy link
Member

makes sense @mmarkelov :)
Have you created an organisation with the name jest-playwright?
Seems already taken, weird.

@mmarkelov
Copy link
Member

@mxschmitt noup, it wasn't me)

@mxschmitt
Copy link
Member

mxschmitt commented Apr 10, 2020

@thernstig we'll give him 1 week to respond, otherwise we will rewrite the package in TypeScript in a fork.

Also we are now under an organisation, maybe you already realised it. )

@thernstig
Copy link
Contributor Author

I did realize 🥂 Nice to see this whole community of packages progressing.

@thernstig
Copy link
Contributor Author

@mxschmitt Any chance you want to fork it :)? I've got three issues reported, no reply:

argos-ci/jest-puppeteer#342
argos-ci/jest-puppeteer#341
argos-ci/jest-puppeteer#340

@mxschmitt
Copy link
Member

Not sure if we should proceed with that. The future is probably something like that: microsoft/playwright-test#9

cc @mmarkelov what do you think?

@thernstig
Copy link
Contributor Author

@mxschmitt Interesting. I had missed playwright-runner entirely, thanks. How you do recon that will pan out in relation to jest-playwright?

@mxschmitt
Copy link
Member

@mxschmitt Interesting. I had missed playwright-runner entirely, thanks. How you do recon that will pan out in relation to jest-playwright?

It will probably replace jest-playwright in the long term. But still heavily under development.

@mmarkelov
Copy link
Member

@mxschmitt @thernstig I suppose we should fork it for a while. Cause playwright-runner is under development

@thernstig
Copy link
Contributor Author

@mmarkelov If you wish I would of course not mind 😄

@mmarkelov
Copy link
Member

I think we can close it. We got jest-process-manager

@mmarkelov
Copy link
Member

@thernstig we just published new prerelease version, it used jest-process-manager. You can try it:
npm install jest-playwright-preset@next

@thernstig
Copy link
Contributor Author

Awesome, will try to test this next week. Swamped with work right now. Looking forward to playwright-community/jest-process-manager#4 sometime in the future as well :)

@thernstig
Copy link
Contributor Author

@mmarkelov @mxschmitt I've tested it and it works. Sorry for testing it so late!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants