Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing tests return exit code 0 instead of 1 #55

Closed
JakeStevenson opened this issue Feb 28, 2020 · 1 comment · Fixed by #57
Closed

Failing tests return exit code 0 instead of 1 #55

JakeStevenson opened this issue Feb 28, 2020 · 1 comment · Fixed by #57
Assignees
@mxschmitt
Labels
bug Something isn't working

Comments

@JakeStevenson
Copy link

I set up a failing jest test. I observed the following behavior:

./node_modules/.bin/jest
--- TEST RUN ---
echo $?
1

When run with jest-playwright:

./node_modules/.bin/jest-playwright
--- TEST RUN ---
echo $?
0

This makes usage of jest-playwright in a CI system difficult.
@mxschmitt mxschmitt self-assigned this Feb 28, 2020
@mxschmitt mxschmitt added the bug Something isn't working label Feb 28, 2020
@mxschmitt
Copy link
Member

I'm on it, will take a look tomorrow

@mxschmitt mxschmitt mentioned this issue Feb 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mxschmitt mxschmitt

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: set correct process exit code playwright-community/jest-playwright
2 participants
@JakeStevenson @mxschmitt