Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set correct process exit code #57

Merged
merged 2 commits into from
Mar 1, 2020
Merged

feat: set correct process exit code #57

merged 2 commits into from
Mar 1, 2020

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Feb 28, 2020

An idea how to implement it. What do you think @mmarkelov?

Closes #55

@mmarkelov
Copy link
Member

@mxschmitt that's ok. It will close an issue, but it shouldn't be so massive error about it I suppose:
Снимок экрана 2020-02-29 в 11 50 24

I don't have much experience with customization of this error.

@mxschmitt mxschmitt marked this pull request as ready for review February 29, 2020 09:28
@mxschmitt
Copy link
Member Author

mxschmitt commented Feb 29, 2020

I think this message cant be customised. Maybe we can add another log message before we exit with 1 that One of the test has not passed successfully.

@mmarkelov
Copy link
Member

mmarkelov commented Feb 29, 2020

@mxschmitt I think there is way to customize this message. For now we can add log message before exit. But I’ll try to find out solution to customization

@mmarkelov mmarkelov merged commit 28670ea into master Mar 1, 2020
@mmarkelov mmarkelov deleted the bugfix/exit-code branch March 1, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing tests return exit code 0 instead of 1
2 participants