Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong set options #589

Closed
mmarkelov opened this issue Feb 19, 2021 · 0 comments · Fixed by #590
Closed

Wrong set options #589

mmarkelov opened this issue Feb 19, 2021 · 0 comments · Fixed by #590
Labels
bug Something isn't working

Comments

@mmarkelov
Copy link
Member

Describe the bug
Wrong passing options with this case.

// jest-playwright.config.js
...
contextOptions: {
  firefox: {...}
}

To Reproduce

  1. Looks good
// jest-playwright.config.js
...
browsers: ['firefox', 'webkit'],
contextOptions: {
  firefox: {
    ignoreHTTPSErrors: true,
  }
}
  1. Ignores specific options
// jest-playwright.config.js
...
browsers: ['webkit', 'firefox'],
contextOptions: {
  firefox: {
    ignoreHTTPSErrors: true,
  }
}

Expected behavior
Should work for two cases

@mmarkelov mmarkelov added the bug Something isn't working label Feb 19, 2021
mmarkelov added a commit that referenced this issue Feb 19, 2021
mmarkelov added a commit that referenced this issue Feb 19, 2021
* Fix unnecessary mutation of options

close #589

* Fix getBrowserOptions mutation

* Fix getBrowserOptions tests

* Fix lint

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant