-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add jest-playwright as an ESLint environment #80
Comments
@thernstig that's make sense |
@thernstig could you try https://github.com/mxschmitt/eslint-plugin-jest-playwright? |
@mxschmitt I verified that it works. A question though. The implementation has this: module.exports = {
configs: {
recommended: {
env: {
node: true,
jest: true,
},
globals: {
browser: true,
context: true,
page: true,
jestPlaywright: true,
}
}
},
} Isn't this more proper? module.exports = {
configs: {
recommended: {
env: {
shared-node-browser: true,
jest: true,
},
globals: {
browser: true,
context: true,
page: true,
jestPlaywright: true,
}
}
},
} Reason being that you can just |
good catch, will adjust this in a bit! :) |
https://eslint.org/docs/user-guide/configuring#specifying-environments has a way to configure environments. It would be cool if jest-playwright was part of that, but I am not sure how feasible that is. This would avoid having to specify the globals that come with jest-playwright.
Maybe not worth it and then you can close this, but I just thought I'd bring up the idea even how minor it might be.
The text was updated successfully, but these errors were encountered: