Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inherit from default config on objects #15

Merged
merged 2 commits into from
Feb 7, 2020
Merged

feat: inherit from default config on objects #15

merged 2 commits into from
Feb 7, 2020

Conversation

mxschmitt
Copy link
Member

Currently we have to provide the webSocket: true value manually if we are using a custom launchBrowserApp setting.
With this change the launchBrowserApp and config option will inherit from the default config, so that we don't have to specify it.

@mmarkelov
Copy link
Member

LGTM! @mxschmitt thanks!

@mmarkelov mmarkelov merged commit 37a30dc into playwright-community:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants