New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs fixes #202
Docs fixes #202
Conversation
Pull Request Test Coverage Report for Build 160316692
💛 - Coveralls |
lgtm, but we probably have to add playwright-core as a dev dependency since its not installed by default anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment
@mxschmitt maybe you are talking about to add it to dependencies? |
yep, sorry! I mean dependencies 👍 So that playwright-core will be installed with our package. |
@mxschmitt got it and move it =) |
Also fix a bug from #203, cause when we are passing jest-playwright/src/PlaywrightEnvironment.ts Lines 86 to 91 in 0e7228d
|
@mxschmitt, could you plz check it out? It's ok with local, but seems like that there is a problem with github actions |
close #191 #194 and perhaps #144