Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs fixes #202

Merged
merged 7 commits into from Jul 7, 2020
Merged

Docs fixes #202

merged 7 commits into from Jul 7, 2020

Conversation

mmarkelov
Copy link
Member

close #191 #194 and perhaps #144

@mmarkelov mmarkelov requested a review from mxschmitt as a code owner July 7, 2020 07:42
@github-actions
Copy link

github-actions bot commented Jul 7, 2020

Pull Request Test Coverage Report for Build 160316692

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.143%

Totals Coverage Status
Change from base Build 160291685: 0.0%
Covered Lines: 84
Relevant Lines: 88

💛 - Coveralls

@mxschmitt
Copy link
Member

lgtm, but we probably have to add playwright-core as a dev dependency since its not installed by default anymore.

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

@mmarkelov
Copy link
Member Author

mmarkelov commented Jul 7, 2020

we probably have to add playwright-core as a dev dependency

@mxschmitt maybe you are talking about to add it to dependencies?

@mxschmitt
Copy link
Member

we probably have to add playwright-core as a dev dependency

@mxschmitt maybe you are talking about to add it to dependencies?

yep, sorry! I mean dependencies 👍 So that playwright-core will be installed with our package.

@mmarkelov
Copy link
Member Author

@mxschmitt got it and move it =)

@mmarkelov
Copy link
Member Author

Also fix a bug from #203, cause when we are passing connectOptions they are ignored

if (
wsEndpoint &&
!this._jestPlaywrightConfig.connectOptions?.wsEndpoint
) {
this._jestPlaywrightConfig.connectOptions = { wsEndpoint }
}

@mmarkelov
Copy link
Member Author

mmarkelov commented Jul 7, 2020

@mxschmitt, could you plz check it out? It's ok with local, but seems like that there is a problem with github actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: reference to official examples
2 participants