Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected some error messages #498

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Corrected some error messages #498

merged 1 commit into from
Dec 20, 2020

Conversation

ocavue
Copy link
Contributor

@ocavue ocavue commented Dec 20, 2020

In #146, server in the config was renamed to serverOptions. However, the error message wasn't updated.

This PR corrects the error message.

@coveralls
Copy link

coveralls commented Dec 20, 2020 •
edited

Pull Request Test Coverage Report for Build 433588408

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.45%
Totals Coverage Status
Change from base Build 428025657: 0.0%
Covered Lines: 107
Relevant Lines: 109
💛 - Coveralls

mxschmitt
mxschmitt approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@mxschmitt mxschmitt merged commit 807e09c into playwright-community:master Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

@mmarkelov mmarkelov Awaiting requested review from mmarkelov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ocavue @coveralls @mxschmitt