Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: package.json installation of playwright #51

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Feb 24, 2020

Have to add docs in the README.

Closes #49

package.json Show resolved Hide resolved
@mxschmitt mxschmitt marked this pull request as ready for review February 24, 2020 08:42
@mxschmitt
Copy link
Member Author

For me the documentation in the README looks already pretty clear. That you have to either install playwright or the standalone playwright packages.

@mmarkelov
Copy link
Member

I suppose that documentation should be clearer. We should think about it.
For now we can merge it

@mmarkelov
Copy link
Member

I think we are ready to publish new version with this PR

@mxschmitt mxschmitt merged commit 894cfcf into master Feb 24, 2020
@mxschmitt mxschmitt deleted the bugfix/installation-npm branch February 24, 2020 08:56
@mxschmitt
Copy link
Member Author

I think we are ready to publish new version with this PR

sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

playwright-firefox and friends always installed
2 participants