Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to check browsers #74

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Fixes to check browsers #74

merged 2 commits into from
Mar 24, 2020

Conversation

mmarkelov
Copy link
Member

Actually I didn't know the best way for this case. May be we should warn user that he try to run tests in parallel for only one. For now I just decided to run tests for only one browser, but I'm not sure that is right approach

Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know either but maybe can we have tests for that edge case?

@mmarkelov mmarkelov merged commit 636970a into master Mar 24, 2020
@mmarkelov mmarkelov deleted the Fixes-to-check-browsers branch March 24, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants