Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roll to Playwright v1.30.0 #344

Closed
wants to merge 12 commits into from
Closed

Conversation

canstand
Copy link
Collaborator

I'm trying a rolling upgrade to support the new Playwright version, which is currently v1.30.0. Errors encountered in the existing test code have been fixed.

Please review.

@canstand
Copy link
Collaborator Author

TestBrowserTypeConnectShouldEmitDisconnectedEvent tends to fail when testing directly, but works fine when debugging. After investigation, the difference is as shown in the figure below, title appears before closed and the error is null. Haven't found the root cause yet.

test_failure

@canstand canstand closed this Apr 16, 2023
@canstand canstand deleted the roll branch April 16, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant