Roll to Playwright v1.36.1 #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Jul 18, 2023
CONTRIBUTING.md
Outdated
| 1. Fix merge conflicts if any, otherwise ignore this step. Once you are happy you can commit the changes `cd playwright; git commit -am "apply patch" && cd ..` | ||
| 1. Regenerate a new patch `bash scripts/update-patch.sh` | ||
| 1. Generate go code `go generate ./...` | ||
| 2. Download current version of Playwright driver `go run scripts/install-browsers/main.go` |
There was a problem hiding this comment.
nit: its kinda nice to keep 1. everywhere, since then the numbers get auto-generated and its a smaller diff when steps are added or removed.
mxschmitt
reviewed
Jul 18, 2023
tests/page_test.go
Outdated
| require.Equal(t, val, 42) | ||
| val, err = page.Evaluate(`a => a`, 17) | ||
| require.NoError(t, err) | ||
| require.Equal(t, val, 17) |
There was a problem hiding this comment.
sounds like there is this? https://pkg.go.dev/math/big
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mxschmitt , this pr rolling to v1.36.1.
Currently there is no automatic generation of
scripts/data/interfaces.json, butvalidate-interfaces.jshas been added togenerate-api.sh. This ensures that unimplemented interfaces are all explicitly ignored invalidate-interfaces.js.