Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browserContext.options nil panic #361

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Fix browserContext.options nil panic #361

merged 2 commits into from
Jul 24, 2023

Conversation

Sacrond
Copy link
Contributor

@Sacrond Sacrond commented Jul 23, 2023

This is to fix the following issue.

#360

@canstand
Copy link
Collaborator

add just these 3 lines to browser_context.go should work, please test

图片
func (b *browserContextImpl) setOptions(options *BrowserNewContextOptions, tracesDir *string) {
	if options == nil {   // line 543
		options = &BrowserNewContextOptions{}
	}
	b.options = options

@Sacrond
Copy link
Contributor Author

Sacrond commented Jul 23, 2023

Adding the 3 lines mentioned to browser_context.go does seem to fix the issue. Updated the commit to just append the 3 lines instead.

Copy link
Collaborator

@canstand canstand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxschmitt mxschmitt merged commit 7538b17 into playwright-community:main Jul 24, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants