Roll to Playwright v1.38.1 #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
approved these changes
Oct 4, 2023
| t.Fatalf("could not set PLAYWRIGHT_BROWSERS_PATH: %v", err) | ||
| } | ||
| defer os.Unsetenv("PLAYWRIGHT_BROWSERS_PATH") | ||
| err = driver.Install() |
There was a problem hiding this comment.
why not pass the env to driver.Install instead?
There was a problem hiding this comment.
It just prevents this test from uninstall the default installed browser (in github action cache), which would affect other tests.
The document mentions multiple environment variables, and users can set them by themselves if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
escapeRegexForSelectorwithout "insert a backslash to even number of backslashes followed by the quote", it seems no errorPlaywrightDriver.Uninstallfor user case Install failed with error and after that next install giving error and exiting #372