refactor(transport): handle transport error, no more log.Fatal #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
reviewed
Dec 14, 2023
browser_context.go
Outdated
| } | ||
| timeout := b.timeoutSettings.Timeout() | ||
| select { | ||
| case <-time.After(time.Duration(timeout) * time.Millisecond): |
There was a problem hiding this comment.
this looks different to what we do upstream: https://github.com/microsoft/playwright/blob/e31e5b1b7c7628921875c98cc98ebdfb2b53b766/packages/playwright-core/src/client/browserContext.ts#L435
There was a problem hiding this comment.
My bad, what really works here is the previous if err != nil. removed with 99c5b11
mxschmitt
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After refactoring the transport, the unexpected exit of
playwright cliwill not cause hang or the main program to exit directly.