New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: StorageState can convert to OptionalStorageState (close #414) #418

Merged

canstand merged 1 commit into playwright-community:main from canstand:issue-414

Feb 9, 2024

Collaborator

canstand commented Feb 8, 2024

This PR avoids manual conversion when there is no need to store StorageState as a file (solve #414)

storageState, _ = context1.StorageState()

context2, _ := browser.NewContext(
	playwright.BrowserNewContextOptions{
		StorageState: storageState.ToOptionalStorageState(),
	})


          feat: StorageState can convert to OptionalStorageState

d20e12b

canstand marked this pull request as ready for review

February 8, 2024 11:13

mxschmitt approved these changes

View reviewed changes

canstand merged commit a6f1d21 into playwright-community:main

13 checks passed

canstand deleted the issue-414 branch

February 10, 2024 09:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment