Use PLAYWRIGHT_NODEJS_PATH in getNodeExecutable
#468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonmeyer-wk
changed the title
carsonmeyer-wk
changed the title
getNodeExecutable
mxschmitt
approved these changes
Jun 17, 2024
run_test.go
Outdated
| @@ -88,6 +89,21 @@ func TestShouldNotHangWhenPlaywrightUnexpectedExit(t *testing.T) { | |||
| require.Error(t, err) | |||
| } | |||
|
|
|||
| func TestGetNodeExecutable(t *testing.T) { | |||
| // When PLAYWRIGHT_NODEJS_PATH is set, use that path. | |||
| err := os.Setenv("PLAYWRIGHT_NODEJS_PATH", "envDir") | |||
There was a problem hiding this comment.
Suggested change
| err := os.Setenv("PLAYWRIGHT_NODEJS_PATH", "envDir") | |
| err := os.Setenv("PLAYWRIGHT_NODEJS_PATH", "foo/node.exe") |
since envDir should be more like a file to the Node.js bindary.
There was a problem hiding this comment.
Makes sense, I can change!
mxschmitt
approved these changes
Jun 17, 2024
|
@mxschmitt Could I get a release that has this PR in it? |
|
done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In playwright-go v0.4400.0 some functionality was regressed with the
PLAYWRIGHT_NODEJS_PATHenv var asplaywright.Runcommand no longer respects it. I have a fix for it but any suggestions to my changes are welcome. Thanks!