Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing methods #74

Merged
merged 5 commits into from
Dec 29, 2020
Merged

add missing methods #74

merged 5 commits into from
Dec 29, 2020

Conversation

lcmtwn
Copy link
Contributor

@lcmtwn lcmtwn commented Dec 29, 2020 •
edited

Relates #34

add below methods:
Frame.Tap
Page.Frame
Page.Tap

@lcmtwn
add missing method
964d431 
Page.Frame
@lcmtwn
add missing methods
084d464 
Frame.Tap
Page.Tap
@lcmtwn lcmtwn marked this pull request as ready for review December 29, 2020 09:13
@lcmtwn lcmtwn changed the title add missing method add missing methods Dec 29, 2020
mxschmitt
mxschmitt approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

generated_interfaces.go Outdated Show resolved Hide resolved
scripts/data/interfaces.json Show resolved Hide resolved
@mxschmitt mxschmitt merged commit dc932a7 into playwright-community:master Dec 29, 2020
@mxschmitt
Copy link
Member

Thanks! really appreciate it.

@lcmtwn lcmtwn deleted the missing-methods branch December 30, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lcmtwn @mxschmitt