Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing methods #78

Merged
merged 2 commits into from
Dec 31, 2020
Merged

add missing methods #78

merged 2 commits into from
Dec 31, 2020

Conversation

lcmtwn
Copy link
Contributor

@lcmtwn lcmtwn commented Dec 31, 2020

relates #34

methods:
ElementHandle.Tap
ElementHandle.ToString
Page.Touchscreen
Touchscreen.Tap
WebSocket.IsClosed

@lcmtwn
add methods
e4358ec 
ElementHandle.Tap
ElementHandle.ToString
Page.Touchscreen
Touchscreen.Tap
WebSocket.IsClosed
@lcmtwn
refine TestElementHandleTap case
fbe6d1c
@lcmtwn lcmtwn marked this pull request as ready for review December 31, 2020 13:06
mxschmitt
mxschmitt approved these changes Dec 31, 2020
View reviewed changes
Copy link
Member

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@mxschmitt mxschmitt merged commit 80f49ad into playwright-community:master Dec 31, 2020
@lcmtwn lcmtwn deleted the missing-methods branch January 4, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxschmitt mxschmitt mxschmitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lcmtwn @mxschmitt