This repository has been archived by the owner on May 25, 2021. It is now read-only.
bytcr-rt5640 and -rt5651improvements #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwrdegoede
added a commit
to jwrdegoede/alsa-lib
that referenced
this pull request
May 8, 2018
This commit adds the generic UCM profiles for bytcr-rt5640 boards from: https://github.com/plbossart/UCM, plus the fixes from this pull-req: plbossart/UCM#31 Note this profile exports all inputs and both stereo/mono speaker setups even though a typical device will not use all. Ideally a long-name based device specific profile should be used instead. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
|
On 5/8/18 10:52 AM, Hans de Goede wrote:
Hi Pierre,
Here are various bytcr-rt5640 and -rt5651UCM profile improvements,
matching the kernel work I've been doing recently.
Hi Hans,
I am not able to deal with this right now unfortunately, the updates in
the kernel broke parts of SOF and I fried the only eval board I had..
Maybe in 2-3 weeks, feel free to push this to alsa-lib in the mean time.
Regards
-Pierre
…
Regards,
Hans
------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#31
Commit Summary
* bytcr-rt5651: Add support for boards using SSP0
* bytcr-rt5651: Change Speaker/Headphone en/disable sequences to fix
switching
* bytcr-rt5651: Make sure all inputs are off by default
* bytcr-rt5640: Various analog microphone fixes
* bytcr-rt5640: Fix mixing of right channel to left speaker
* bytcr-rt5640: Add missing MonoSpeaker to Headphones conflicting
devices list
* bytcr-rt5640: Boost Speaker volume from 29 to 35
File Changes
* *M* bytcr-rt5640/HiFi
<https://github.com/plbossart/UCM/pull/31/files#diff-0> (65)
* *M* bytcr-rt5651/HiFi.conf
<https://github.com/plbossart/UCM/pull/31/files#diff-1> (22)
* *M* bytcr-rt5651/bytcr-rt5651.conf
<https://github.com/plbossart/UCM/pull/31/files#diff-2> (24)
Patch Links:
* https://github.com/plbossart/UCM/pull/31.patch
* https://github.com/plbossart/UCM/pull/31.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#31>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABGIaxe0pCJN3EcQvqURiBaDgOwgF0pGks5twb9WgaJpZM4T25mv>.
|
jwrdegoede
force-pushed
the
bytcr-rt5640-rt5651
branch
from
e6be2d0
to
b11cde0
Compare
jwrdegoede
added a commit
to jwrdegoede/alsa-lib
that referenced
this pull request
May 18, 2018
This commit adds the generic UCM profile for bytcr-rt5640 boards from: https://github.com/plbossart/UCM, plus the fixes from this pull-req: plbossart/UCM#31 The profile has been split up into separate per input / output files to allow for creation of long-name profiles with the specific input / output combinations found on a board without needing to copy and paste things. Note this profile exports all inputs and both stereo/mono speaker setups even though a typical device will not use all. Ideally a long-name based device specific profile made up of the various parts should be used instead. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
jwrdegoede
added a commit
to jwrdegoede/alsa-lib
that referenced
this pull request
May 29, 2018
This commit adds the generic UCM profile for bytcr-rt5640 boards from: https://github.com/plbossart/UCM, plus the fixes from this pull-req: plbossart/UCM#31 The profile has been split up into separate per input / output files to allow for creation of long-name profiles with the specific input / output combinations found on a board without needing to copy and paste things. Note this profile exports all inputs and both stereo/mono speaker setups even though a typical device will not use all. Ideally a long-name based device specific profile made up of the various parts should be used instead. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
jwrdegoede
force-pushed
the
bytcr-rt5640-rt5651
branch
from
b11cde0
to
900b446
Compare
jwrdegoede
added a commit
to jwrdegoede/alsa-lib
that referenced
this pull request
May 31, 2018
This commit adds the generic UCM profile for bytcr-rt5640 boards from: https://github.com/plbossart/UCM, plus the fixes from this pull-req: plbossart/UCM#31 The profile has been split up into separate per input / output files to allow for creation of long-name profiles with the specific input / output combinations found on a board without needing to copy and paste things. Note this profile exports all inputs and both stereo/mono speaker setups even though a typical device will not use all. Ideally a long-name based device specific profile made up of the various parts should be used instead. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
jwrdegoede
force-pushed
the
bytcr-rt5640-rt5651
branch
from
900b446
to
bbd7525
Compare
jwrdegoede
added a commit
to jwrdegoede/alsa-lib
that referenced
this pull request
Jun 1, 2018
This commit adds the generic UCM profile for bytcr-rt5640 boards from: https://github.com/plbossart/UCM, plus the fixes from this pull-req: plbossart/UCM#31 The profile has been split up into separate per input / output files to allow for creation of long-name profiles with the specific input / output combinations found on a board without needing to copy and paste things. Note this profile exports all inputs and both stereo/mono speaker setups even though a typical device will not use all. Ideally a long-name based device specific profile made up of the various parts should be used instead. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Add support for bytcr-rt5651 boards using SSP0. Note that only SSP0 is available on Bay Trail CR tablets. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
…itching pulseaudio will run the DisableSequence of the current playback device before running the EnableSequence of the new playback device. This causes the Platform Clock and BIAS to temporarily get turned off which breaks audio-streams which are playing when switching. This commit moves the disabling to the EnableSequence of the other device fixing this. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This fixes the platform clock being kept on by these in some cases. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
The headdphones can either be driven directly from DAC1, or through
the HP volume mixer chain to allow volume control.
Mix only DAC1 to the headphones and not the HP volume path, there
are 3 reasons to choice the DAC1 path;
1) It is the power-on-reset default
2) We don't expose the volume control to e.g. pulseaudio anyways so it
is not useful
3) Older versions of the UCM profile set the "HP Playback Volume" to 0,
effectively disabling it
While at it also remove the old:
cset "name='HP Playback Volume' 0"
setting, this is a no-op for a while now as it gets overidden by the 0Db
setting a couple lines lower:
cset "name='HP Playback Volume' 31"
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Various analog microphone fixes for bytcr-rt5640: -Move things which we only need to do once like setting muxes and volumes to the global enable-sequence where they can be shared between all inputs -Set ADC Capture volume to 63 which is 6dB -Set 'ADC Boost Gain' to 1 / 3dB -Set 'IN1 Boost' to 8 (max), this also syncs it with IN3 which makes sense as various devices use either IN1 or IN3 -Add Mono ADC enabling/disabling to HeadsetMic, without this it won't work -Disable 'RECMIX? BST? Switch' switches on input disable, so that we don't have multiple boost inputs selected at the same time when switching -Start with all Mic switches disabled Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Fix mixing of right channel to left speaker when switching from MonoSpeaker to Speaker. The fix is done in the enable sequence of the regular Speaker setting to also fix this in saved mixer settings. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
…es list Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Setting the speaker volume to 29 (-3dB) leads to quite soft max volume one some devices, boost this to 35. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
One of the lines in the Headphones section starts with set instead of cset, fix this. Signed-off-by: Hans de Goede <hdegoede@redhat.com>
jwrdegoede
force-pushed
the
bytcr-rt5640-rt5651
branch
from
bbd7525
to
4646d50
Compare
perexg
pushed a commit
to alsa-project/alsa-ucm-conf
that referenced
this pull request
Sep 24, 2019
This commit adds the generic UCM profile for bytcr-rt5640 boards from: https://github.com/plbossart/UCM, plus the fixes from this pull-req: plbossart/UCM#31 The profile has been split up into separate per input / output files to allow for creation of long-name profiles with the specific input / output combinations found on a board without needing to copy and paste things. Note this profile exports all inputs and both stereo/mono speaker setups even though a typical device will not use all. Ideally a long-name based device specific profile made up of the various parts should be used instead. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Pierre,
Here are various bytcr-rt5640 and -rt5651UCM profile improvements, matching the kernel work I've been doing recently.
Regards,
Hans