Skip to content

Commit

Permalink
target/avr/disas: Fix store instructions display order
Browse files Browse the repository at this point in the history
While LOAD instructions use the target register as first
argument, STORE instructions use it as second argument:

  LD Rd, X        // Rd <- (X)

  ST Y, Rd        // (Y) <- Rr

Reported-by: Joaquin de Andres <me@xcancerberox.com.ar>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20200707070021.10031-4-f4bug@amsat.org>
  • Loading branch information
philmd committed Jul 11, 2020
1 parent 2e34e62 commit 19b2934
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions target/avr/disas.c
Original file line number Diff line number Diff line change
Expand Up @@ -195,16 +195,16 @@ INSN(LDZ2, "r%d, Z+", a->rd)
INSN(LDZ3, "r%d, -Z", a->rd)
INSN(LDDY, "r%d, Y+%d", a->rd, a->imm)
INSN(LDDZ, "r%d, Z+%d", a->rd, a->imm)
INSN(STS, "r%d, %d", a->rd, a->imm)
INSN(STX1, "r%d, X", a->rr)
INSN(STX2, "r%d, X+", a->rr)
INSN(STX3, "r%d, -X", a->rr)
INSN(STY2, "r%d, Y+", a->rd)
INSN(STY3, "r%d, -Y", a->rd)
INSN(STZ2, "r%d, Z+", a->rd)
INSN(STZ3, "r%d, -Z", a->rd)
INSN(STDY, "r%d, Y+%d", a->rd, a->imm)
INSN(STDZ, "r%d, Z+%d", a->rd, a->imm)
INSN(STS, "%d, r%d", a->imm, a->rd)
INSN(STX1, "X, r%d", a->rr)
INSN(STX2, "X+, r%d", a->rr)
INSN(STX3, "-X, r%d", a->rr)
INSN(STY2, "Y+, r%d", a->rd)
INSN(STY3, "-Y, r%d", a->rd)
INSN(STZ2, "Z+, r%d", a->rd)
INSN(STZ3, "-Z, r%d", a->rd)
INSN(STDY, "Y+%d, r%d", a->imm, a->rd)
INSN(STDZ, "Z+%d, r%d", a->imm, a->rd)
INSN(LPM1, "")
INSN(LPM2, "r%d, Z", a->rd)
INSN(LPMX, "r%d, Z+", a->rd)
Expand Down

0 comments on commit 19b2934

Please sign in to comment.