Skip to content

Commit

Permalink
target/mips: Don't check COP1X for 64 bit FP mode
Browse files Browse the repository at this point in the history
Some implementations (i.e. Loongson-2F) may decide to implement
a 64 bit FPU without implementing COP1X instructions.

As the eligibility of 64 bit FP instructions is already determined
by CP0St_FR, there is no need to check for COP1X again.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20221102165719.190378-1-jiaxun.yang@flygoat.com>
[PMD: Add missing trailing parenthesis (buildfix)]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
  • Loading branch information
FlyGoat authored and philmd committed Nov 8, 2022
1 parent 4bfc895 commit 2a2105a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion target/mips/tcg/translate.c
Original file line number Diff line number Diff line change
Expand Up @@ -1545,7 +1545,7 @@ void check_cop1x(DisasContext *ctx)
*/
void check_cp1_64bitmode(DisasContext *ctx)
{
if (unlikely(~ctx->hflags & (MIPS_HFLAG_F64 | MIPS_HFLAG_COP1X))) {
if (unlikely(~ctx->hflags & MIPS_HFLAG_F64)) {
gen_reserved_instruction(ctx);
}
}
Expand Down

0 comments on commit 2a2105a

Please sign in to comment.