[RISCV] Porting `riscv-p-ext`. #4

TuringKi · 2023-10-28T06:49:33Z

video :
https://www.bilibili.com/video/BV1nQ4y1W7h9/
https://www.bilibili.com/video/BV1oM411X7eQ/

testsuites generating scripts: https://github.com/TuringKi/riscv-p-ext-spec-insn-parse

build steps:

# clone and build binutils

 git clone -b binutils-2_41-release-point https://github.com/bminor/binutils-gdb.git

cd binutils-gdb && mkdir .build && cd .build

../configure --prefix=`pwd`/../../.install --disable-gdb --target=riscv32-unknown-elf

make -j16 && make install && cd ../../

#prepare newlib and gcc

wget ftp://sourceware.org/pub/newlib/newlib-4.1.0.tar.gz && tar xvf newlib-4.1.0.tar.gz

git clone  -b gcc13-p-rebase  https://github.com/mxlol233-rv/riscv-gcc.git

cd gcc

ln -s ../newlib-4.1.0/newlib ./

mkdir .build && cd .build

# build gcc with p-ext

../configure --prefix=`pwd`/../../.install --target=riscv64-unknown-elf \
--disable-ssp \
--disable-multilib \
--enable-languages=c,c++ \
--disable-bootstrap \
--with-newlib

make -j16 && make install

#do check 
make check-gcc RUNTESTFLAGS="rvp64.exp"

rv32

                === gcc Summary ===

# of expected passes            725

rv64

                === gcc Summary ===

# of expected passes            992

Liaoshihua · 2023-10-30T01:22:29Z

gcc/config/riscv/riscv-c.cc

@@ -18,6 +18,7 @@ You should have received a copy of the GNU General Public License
 along with GCC; see the file COPYING3.  If not see
 <http://www.gnu.org/licenses/>.  */



This file does not need to be altered.
When you add sub-extendsion in riscv-common.cc, the marco like __riscv_zbpbo will be generated.

Liaoshihua · 2023-10-30T01:26:12Z

gcc/config/riscv/riscv-builtins.cc

@@ -18,6 +18,7 @@ You should have received a copy of the GNU General Public License
 along with GCC; see the file COPYING3.  If not see
 <http://www.gnu.org/licenses/>.  */

+#include "config/riscv/riscv-opts.h"


This one doesn't need to

yes, the clang-format add it automatically. I should delete it.

Liaoshihua · 2023-10-30T01:29:28Z

gcc/config/riscv/t-riscv

@@ -8,7 +8,8 @@ riscv-builtins.o: $(srcdir)/config/riscv/riscv-builtins.cc $(CONFIG_H) \
  $(DIAGNOSTIC_CORE_H) $(OPTABS_H) $(RISCV_BUILTINS_H) \
  $(srcdir)/config/riscv/riscv-ftypes.def \
  $(srcdir)/config/riscv/riscv-vector-builtins-types.def \
-  $(srcdir)/config/riscv/riscv-modes.def
+  $(srcdir)/config/riscv/riscv-modes.def \
+  $(srcdir)/config/riscv/riscv-builtins-rvp.def


if you included it in riscv-builtin.cc, no need to add here

I think this line is for that if riscv-builtins-rvp.def has been modified, the make tool should be able to detect this modification and rebuild it.

TuringKi · 2023-10-30T01:56:12Z

@Liaoshihua Thanks for your review, I will make some changes to the patch later tonight.

yulong18 · 2023-10-30T04:40:05Z

gcc/config/riscv/riscv-builtins.cc

+AVAIL (zbpbo, TARGET_ZBPBO)
+AVAIL (zbpbo32, TARGET_ZBPBO && !TARGET_64BIT)
+AVAIL (zbpbo64, TARGET_ZBPBO &&TARGET_64BIT)
+


A uniform format is recommended here. For example, “AVAIL (zpn64, TARGET_ZPN && TARGET_64BIT)”

ok, clang-format action missing...

XYenChi · 2023-10-30T05:36:22Z

gcc/testsuite/gcc.target/riscv/rvp32/builtin-rvp32-add64.c

+
+int64_t f0 (int64_t x0, int64_t x1){
+
+    return __rv_sadd64(x0, x1);


riscv c api format changed to __riscv_
riscv-non-isa/riscv-c-api-doc#31

I'm not sure should to follow the spec of p-ext format (https://github.com/riscv/riscv-p-spec/blob/master/P-ext-proposal.adoc#73-add64-64-bit-addition) or the one on this page(riscv-non-isa/riscv-c-api-doc#31) ?

Leave it as it is for now, and wait for the new p-ext proposal to come out before deciding

I'm not sure about it now. Maybe as a existed format, should follow the spec.

Liaoshihua reviewed Oct 30, 2023

View reviewed changes

yulong18 reviewed Oct 30, 2023

View reviewed changes

XYenChi reviewed Oct 30, 2023

View reviewed changes

TuringKi force-pushed the gcc13-p-rebase branch from f60ecca to e016063 Compare October 30, 2023 11:45

[RISCV] Porting riscv-p-ext.

fa991fe

TuringKi force-pushed the gcc13-p-rebase branch from e016063 to fa991fe Compare October 30, 2023 11:49

TuringKi requested review from Liaoshihua, yulong18 and XYenChi October 30, 2023 11:50

pz9115 merged commit b71e4a4 into plctlab:gcc13-p-rebase Nov 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RISCV] Porting `riscv-p-ext`. #4

[RISCV] Porting `riscv-p-ext`. #4

TuringKi commented Oct 28, 2023 •

edited

Loading

Liaoshihua Oct 30, 2023 •

edited

Loading

Liaoshihua Oct 30, 2023

TuringKi Oct 30, 2023

Liaoshihua Oct 30, 2023

TuringKi Oct 30, 2023 •

edited

Loading

TuringKi commented Oct 30, 2023

yulong18 Oct 30, 2023

TuringKi Oct 30, 2023

XYenChi Oct 30, 2023

TuringKi Oct 30, 2023

Liaoshihua Oct 30, 2023

XYenChi Oct 30, 2023

		@@ -18,6 +18,7 @@ You should have received a copy of the GNU General Public License
		along with GCC; see the file COPYING3. If not see
		<http://www.gnu.org/licenses/>. */


		int64_t f0 (int64_t x0, int64_t x1){

		return __rv_sadd64(x0, x1);

[RISCV] Porting riscv-p-ext. #4

[RISCV] Porting riscv-p-ext. #4

Conversation

TuringKi commented Oct 28, 2023 • edited Loading

Liaoshihua Oct 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TuringKi Oct 30, 2023 • edited Loading

Choose a reason for hiding this comment

TuringKi commented Oct 30, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

[RISCV] Porting `riscv-p-ext`. #4

[RISCV] Porting `riscv-p-ext`. #4

TuringKi commented Oct 28, 2023 •

edited

Loading

Liaoshihua Oct 30, 2023 •

edited

Loading

TuringKi Oct 30, 2023 •

edited

Loading