Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple id values in controller action authorization #39

Merged
merged 3 commits into from Sep 10, 2014

Conversation

matthewjrose87
Copy link
Contributor

Minimized the upstream differences that were in request #38

@pmcneil
Copy link
Collaborator

pmcneil commented Aug 22, 2014

Thanks Matthew.

Looking at this you're trying to make a permstring like:

book:delete:23,34,45,67,82

which is fair enough, but is that usable out of the box???

How would we document it and it's use? (hint: please provide doco :-) )

@matthewjrose87
Copy link
Contributor Author

Peter,

The modification simply allows you to pass multiple id values to a controller/action when using the default authorization method.

For instance, in our application there are many scenarios where we may make a request for something like:

/vehicle/status?id=5&id=7&id=13 instead of requesting /vehicle/status/5, /vehicle/status/7, etc separately.

The existing default authorization method doesn't support this, but shiro itself is plenty capable of checking against a permission string with multiple instance IDs.

@pmcneil
Copy link
Collaborator

pmcneil commented Sep 10, 2014

Sounds good, and looks good, I'll merge it. We really need some help with the doco including example projects if you're interested??

pmcneil added a commit that referenced this pull request Sep 10, 2014
Support multiple id values in controller action authorization
@pmcneil pmcneil merged commit 3063522 into pledbrook:master Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants