Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

formula popup should be fixed, or closed when scrolling #272

Closed
z4cki opened this issue Jul 7, 2022 · 5 comments
Closed

formula popup should be fixed, or closed when scrolling #272

z4cki opened this issue Jul 7, 2022 · 5 comments
Assignees
@melchior-voidwolf
Labels
bug Something isn't working formula Related to the formula module

Comments

@z4cki
Copy link
Contributor

z4cki commented Jul 7, 2022

Describe the bug

Formula - popup should be fixed, or closed when scrolling

To Reproduce

https://www.loom.com/share/786b3470c7df420a99bbf93eeba0060f

Expected behavior

No response

Additional context

No response

Logs/tracebacks

No response
@z4cki z4cki added the bug Something isn't working label Jul 7, 2022
@stackia
Copy link
Contributor

stackia commented Jul 7, 2022 •
edited
Loading

@BrickDoctor @ziyanchen327 @zaotang Please help confirm the expected behavior

@ziyan-chen
Copy link

@jizhekai when popover opened , we can not scrolling the page , just can scrolling the list in the popover.

@z4cki
Copy link
Contributor Author

z4cki commented Jul 8, 2022

@ziyanchen327 Meaning we are not allowed to scroll the page when we open popover? cc @clszzyh

@toadfanszz
Copy link
Contributor

@stackia Should we implement this feature in popover design system?

@stackia
Copy link
Contributor

stackia commented Jul 8, 2022 •
edited
Loading

@clszzyh yes, this should be implemented at the popover component level.

Popover should provide a new prop to control whether scrolling is disabled on body when opened.

reassigned to @melchior-voidwolf

@0xDing 0xDing changed the title [Bug] Formula - popup should be fixed, or closed when scrolling Formula - popup should be fixed, or closed when scrolling Jul 8, 2022
@0xDing 0xDing changed the title Formula - popup should be fixed, or closed when scrolling formula popup should be fixed, or closed when scrolling Jul 8, 2022
@0xDing 0xDing added the formula Related to the formula module label Jul 8, 2022
@melchior-voidwolf melchior-voidwolf mentioned this issue Jul 27, 2022
Merged
@stackia stackia closed this as completed Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@melchior-voidwolf melchior-voidwolf

Labels
bug Something isn't working formula Related to the formula module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@0xDing @stackia @melchior-voidwolf @z4cki @toadfanszz @ziyan-chen