Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Create new Popover and use in formula block #465

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Conversation

melchior-voidwolf
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #465 (ba003f9) into main (4d598ad) will increase coverage by 0.00%.
The diff coverage is 72.41%.

@@           Coverage Diff           @@
##             main     #465   +/-   ##
=======================================
  Coverage   69.81%   69.82%           
=======================================
  Files        1062     1064    +2     
  Lines       18096    18123   +27     
  Branches     2513     2519    +6     
=======================================
+ Hits        12634    12654   +20     
- Misses       5151     5155    +4     
- Partials      311      314    +3     
Flag Coverage Δ
frontend-unit 65.53% <72.41%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/design-system/src/components/Popover/index.tsx 93.75% <ø> (ø)
.../components/blockViews/FormulaView/FormulaMenu.tsx 43.10% <33.33%> (-1.54%) ⬇️
...es/design-system/src/components/PopoverN/index.tsx 71.42% <71.42%> (ø)
...stem/src/components/PopoverN/styles/index.style.ts 100.00% <100.00%> (ø)
packages/design-system/src/components/index.ts 100.00% <100.00%> (ø)
packages/formula/src/grammar/completer.ts 94.69% <0.00%> (ø)
...d/DocumentTopBar/PathBreadcrumb/PathBreadcrumb.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d598ad...ba003f9. Read the comment docs.

@melchior-voidwolf melchior-voidwolf temporarily deployed to pr_preview July 24, 2022 17:06 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr465.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@melchior-voidwolf melchior-voidwolf merged commit c92d139 into main Jul 25, 2022
@melchior-voidwolf melchior-voidwolf deleted the kailfix branch July 25, 2022 06:50
@melchior-voidwolf
Copy link
Contributor Author

fix #272
fix #423

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants