Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

feat(spreadsheet): spreadsheet related improvement #435

Merged
merged 6 commits into from
Jul 22, 2022
Merged

feat(spreadsheet): spreadsheet related improvement #435

merged 6 commits into from
Jul 22, 2022

Conversation

aligo
Copy link
Contributor

@aligo aligo commented Jul 21, 2022

@aligo aligo linked an issue Jul 21, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #435 (261ef3c) into main (4173f7c) will decrease coverage by 0.04%.
The diff coverage is 12.00%.

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
- Coverage   69.66%   69.62%   -0.05%     
==========================================
  Files        1060     1060              
  Lines       18027    18039      +12     
  Branches     2496     2500       +4     
==========================================
+ Hits        12558    12559       +1     
- Misses       5156     5167      +11     
  Partials      313      313              
Flag Coverage Δ
frontend-unit 65.26% <12.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/blockViews/Spreadsheet/SpreadsheetBlockView.tsx 32.55% <0.00%> (+0.97%) ⬆️
...ents/blockViews/Spreadsheet/SpreadsheetContext.tsx 21.00% <5.88%> (-2.14%) ⬇️
...omponents/blockViews/Spreadsheet/useSpreadsheet.ts 30.40% <33.33%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4173f7c...261ef3c. Read the comment docs.

@aligo aligo temporarily deployed to pr_preview July 21, 2022 02:16 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr435.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@aligo aligo marked this pull request as draft July 21, 2022 12:08
@aligo aligo temporarily deployed to pr_preview July 21, 2022 12:13 Inactive
@aligo aligo marked this pull request as ready for review July 22, 2022 01:32
@aligo aligo enabled auto-merge (squash) July 22, 2022 01:32
@aligo aligo merged commit f94aa20 into main Jul 22, 2022
@aligo aligo deleted the spreadsheet branch July 22, 2022 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants