Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

refactor: ActiveStorage #441

Merged
merged 2 commits into from
Jul 21, 2022
Merged

refactor: ActiveStorage #441

merged 2 commits into from
Jul 21, 2022

Conversation

toadfanszz
Copy link
Contributor

@toadfanszz toadfanszz commented Jul 21, 2022

  1. Introduce rack-cors in development environment to fix CORS error.
  2. Remove current_pod dependency in create_direct_upload
  3. add downloadUrl field to download directly when click download.

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #441 (8a435d6) into main (700eaab) will decrease coverage by 0.00%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   69.70%   69.70%   -0.01%     
==========================================
  Files        1060     1060              
  Lines       18015    18020       +5     
  Branches     2490     2492       +2     
==========================================
+ Hits        12558    12561       +3     
- Misses       5143     5146       +3     
+ Partials      314      313       -1     
Flag Coverage Δ
backend-unit 87.56% <100.00%> (+<0.01%) ⬆️
frontend-unit 65.35% <61.53%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tEditor/useEditorOptions/useEmbed/useGetFileUrl.ts 0.00% <0.00%> (ø)
...Views/EmbedView/embedViews/ImageView/ImageView.tsx 81.48% <ø> (ø)
.../legacy-editor/src/extensions/blocks/embed/meta.ts 100.00% <ø> (ø)
...lith/app/graphql/mutations/create_direct_upload.rb 84.37% <100.00%> (+1.04%) ⬆️
.../src/components/blockViews/EmbedView/EmbedView.tsx 75.00% <100.00%> (+1.56%) ⬆️
...ckViews/EmbedView/embedViews/CardView/CardView.tsx 93.54% <100.00%> (ø)
...ws/EmbedView/embedViews/ImageView/useImageState.ts 92.30% <100.00%> (ø)
...s/EmbedView/embedViews/PreviewView/PreviewView.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700eaab...8a435d6. Read the comment docs.

@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr441.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

Copy link
Contributor

@Darmody Darmody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toadfanszz toadfanszz merged commit 19d1a1d into main Jul 21, 2022
@toadfanszz toadfanszz deleted the fix-active-storage-2 branch July 21, 2022 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download Link block should real download, but not open in tab
2 participants