Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

fix(legacy-editor): do not remove portal when node view destory #446

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

Darmody
Copy link
Contributor

@Darmody Darmody commented Jul 21, 2022

No description provided.

@Darmody Darmody requested a review from toadfanszz as a code owner July 21, 2022 08:39
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #446 (5e0dfca) into main (e4f0ad0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   69.70%   69.69%   -0.01%     
==========================================
  Files        1060     1060              
  Lines       18027    18024       -3     
  Branches     2495     2495              
==========================================
- Hits        12565    12562       -3     
  Misses       5151     5151              
  Partials      311      311              
Flag Coverage Δ
frontend-unit 65.34% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...legacy-editor/src/tiptapRefactor/EditorContent.tsx 75.00% <ø> (-1.32%) ⬇️
...ditor/src/tiptapRefactor/ReactNodeViewRenderer.tsx 56.66% <100.00%> (-1.40%) ⬇️
...legacy-editor/src/tiptapRefactor/ReactRenderer.tsx 66.66% <100.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4f0ad0...5e0dfca. Read the comment docs.

@Darmody Darmody temporarily deployed to pr_preview July 21, 2022 08:51 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr446.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

aligo
aligo previously approved these changes Jul 21, 2022
@Darmody Darmody marked this pull request as draft July 21, 2022 09:31
@Darmody Darmody marked this pull request as ready for review July 21, 2022 09:46
@Darmody Darmody temporarily deployed to pr_preview July 21, 2022 09:52 Inactive
aligo
aligo previously approved these changes Jul 21, 2022
@Darmody Darmody temporarily deployed to pr_preview July 21, 2022 10:02 Inactive
leave dom destroy to prosemirror to avoid react async render issue.
@Darmody Darmody changed the title fix(legacy-editor): make all react node view updation sync fix(legacy-editor): do not remove portal when node view destory Jul 21, 2022
@0xDing 0xDing merged commit 2cdd820 into main Jul 21, 2022
@0xDing 0xDing deleted the fix-flush-sync branch July 21, 2022 10:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants