Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

fix(formula): another deadlock bug #462

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Conversation

toadfanszz
Copy link
Contributor

fix another deadlock bug.

@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr462.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #462 (99b9f11) into main (229a3ce) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   69.81%   69.81%           
=======================================
  Files        1062     1062           
  Lines       18094    18096    +2     
  Branches     2513     2513           
=======================================
+ Hits        12632    12634    +2     
  Misses       5151     5151           
  Partials      311      311           
Flag Coverage Δ
frontend-unit 65.52% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/blockViews/Spreadsheet/SpreadsheetCell.tsx 10.38% <0.00%> (ø)
packages/formula/src/grammar/dependency.ts 86.84% <100.00%> (+0.35%) ⬆️
...s/formula/src/tests/feature/spreadsheetVariable.ts 100.00% <100.00%> (ø)
packages/formula/src/grammar/completer.ts 94.69% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229a3ce...99b9f11. Read the comment docs.

@toadfanszz toadfanszz merged commit 8af9dae into main Jul 23, 2022
@toadfanszz toadfanszz deleted the fix-formula-deadlock2 branch July 23, 2022 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formula dead lock when delete column
2 participants