Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

feat(spreadsheet): spreadsheet related improvement #469

Merged
merged 12 commits into from
Jul 26, 2022
Merged

feat(spreadsheet): spreadsheet related improvement #469

merged 12 commits into from
Jul 26, 2022

Conversation

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #469 (5ec8017) into main (740f649) will decrease coverage by 0.18%.
The diff coverage is 25.31%.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   69.59%   69.41%   -0.19%     
==========================================
  Files        1069     1069              
  Lines       18356    18406      +50     
  Branches     2563     2574      +11     
==========================================
+ Hits        12775    12776       +1     
- Misses       5260     5310      +50     
+ Partials      321      320       -1     
Flag Coverage Δ
backend-unit 87.11% <100.00%> (-0.46%) ⬇️
frontend-unit 65.21% <23.37%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/blockViews/Spreadsheet/SpreadsheetCell.tsx 11.11% <0.00%> (ø)
...ponents/blockViews/Spreadsheet/SpreadsheetView.tsx 13.69% <0.00%> (ø)
...ents/blockViews/Spreadsheet/SpreadsheetContext.tsx 19.68% <9.09%> (-1.33%) ⬇️
...ts/blockViews/Spreadsheet/SpreadsheetBlockView.tsx 32.08% <20.00%> (-0.47%) ⬇️
...omponents/blockViews/Spreadsheet/useSpreadsheet.ts 30.81% <26.08%> (+0.41%) ⬆️
...onolith/app/graphql/mutations/blocks/sync_batch.rb 97.26% <100.00%> (ø)
...onents/blockViews/Spreadsheet/Spreadsheet.style.ts 100.00% <100.00%> (ø)
apps/server-monolith/app/models/docs/block.rb 68.58% <0.00%> (-5.13%) ⬇️
packages/formula/src/grammar/completer.ts 94.69% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740f649...5ec8017. Read the comment docs.

@aligo aligo temporarily deployed to pr_preview July 25, 2022 02:53 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr469.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@aligo aligo temporarily deployed to pr_preview July 26, 2022 03:15 Inactive
@aligo aligo marked this pull request as ready for review July 26, 2022 07:10
@aligo aligo enabled auto-merge (squash) July 26, 2022 07:11
@aligo aligo disabled auto-merge July 26, 2022 07:11
@aligo aligo enabled auto-merge (squash) July 26, 2022 07:11
@aligo aligo temporarily deployed to pr_preview July 26, 2022 07:21 Inactive
@aligo aligo temporarily deployed to pr_preview July 26, 2022 07:55 Inactive
@aligo aligo merged commit 0b25510 into main Jul 26, 2022
@aligo aligo deleted the spreadsheet branch July 26, 2022 12:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants