Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

refactor(formula): runtime dependency track #471

Merged
merged 8 commits into from
Jul 25, 2022

Conversation

toadfanszz
Copy link
Contributor

ref #453

Add ability to track cell dependency.

@toadfanszz toadfanszz marked this pull request as draft July 25, 2022 09:17
@toadfanszz toadfanszz temporarily deployed to pr_preview July 25, 2022 09:21 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr471.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@toadfanszz toadfanszz temporarily deployed to pr_preview July 25, 2022 11:27 Inactive
Signed-off-by: clszzyh <clszzyh@gmail.com>
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #471 (12e4437) into main (c92d139) will increase coverage by 0.16%.
The diff coverage is 94.04%.

@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
+ Coverage   69.82%   69.99%   +0.16%     
==========================================
  Files        1064     1066       +2     
  Lines       18123    18172      +49     
  Branches     2519     2531      +12     
==========================================
+ Hits        12654    12719      +65     
+ Misses       5155     5140      -15     
+ Partials      314      313       -1     
Flag Coverage Δ
frontend-unit 65.76% <94.04%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/formula/src/context/context.ts 79.79% <ø> (+1.51%) ⬆️
packages/formula/src/controls/block.ts 87.71% <ø> (ø)
packages/formula/src/controls/spreadsheet.ts 71.51% <ø> (ø)
packages/formula/src/events/block.ts 100.00% <ø> (ø)
packages/formula/src/events/spreadsheet.ts 87.50% <ø> (ø)
packages/formula/src/tests/testType.ts 83.33% <ø> (ø)
packages/formula/src/type/index.ts 100.00% <ø> (ø)
...ts/blockViews/Spreadsheet/SpreadsheetBlockView.tsx 32.55% <ø> (ø)
...ponents/blockViews/Spreadsheet/SpreadsheetCell.tsx 11.11% <0.00%> (+0.72%) ⬆️
packages/formula/src/tests/feature/index.ts 88.88% <50.00%> (-5.23%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92d139...12e4437. Read the comment docs.

@toadfanszz toadfanszz marked this pull request as ready for review July 25, 2022 14:33
@0xDing 0xDing merged commit 960ae9e into main Jul 25, 2022
@0xDing 0xDing deleted the formula-track-runtime-dependency branch July 25, 2022 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants