Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

refactor(graphql): add policy checking to GraphQL interfaces #486

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Conversation

aligo
Copy link
Contributor

@aligo aligo commented Jul 28, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #486 (e6979ee) into main (7e5723d) will increase coverage by 0.10%.
The diff coverage is 55.17%.

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   69.29%   69.39%   +0.10%     
==========================================
  Files        1070     1069       -1     
  Lines       18416    18392      -24     
  Branches     2573     2569       -4     
==========================================
+ Hits        12762    12764       +2     
+ Misses       5340     5314      -26     
  Partials      314      314              
Flag Coverage Δ
backend-unit 87.14% <84.21%> (+0.03%) ⬆️
frontend-unit 65.18% <0.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Id/_shared/DocumentEditor/useLegacySyncProvider.ts 0.00% <0.00%> (ø)
...t-web/src/routes/$domain/$docId/_shared/graphql.ts 0.00% <ø> (ø)
...server-monolith/app/graphql/resolvers/block_new.rb 54.54% <0.00%> (ø)
...ps/server-monolith/app/graphql/types/query_type.rb 100.00% <ø> (ø)
apps/server-monolith/app/models/docs/block.rb 68.58% <ø> (ø)
.../server-monolith/app/policies/docs/block_policy.rb 92.85% <85.71%> (-7.15%) ⬇️
...er-monolith/app/graphql/mutations/blocks/commit.rb 96.07% <100.00%> (+0.07%) ⬆️
...monolith/app/graphql/mutations/blocks/duplicate.rb 91.66% <100.00%> (+0.75%) ⬆️
...nolith/app/graphql/mutations/blocks/hard_delete.rb 100.00% <100.00%> (ø)
...rver-monolith/app/graphql/mutations/blocks/move.rb 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5723d...e6979ee. Read the comment docs.

@aligo aligo temporarily deployed to pr_preview July 28, 2022 07:32 Inactive
@github-actions
Copy link
Contributor

This pull request has been built and is available for preview at pr486.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@aligo aligo temporarily deployed to pr_preview July 28, 2022 08:27 Inactive
@aligo aligo temporarily deployed to pr_preview July 28, 2022 08:45 Inactive
@aligo aligo changed the title refactor(graphql) refactor(graphql): add policy checking to graphql interfaces Jul 28, 2022
@aligo aligo changed the title refactor(graphql): add policy checking to graphql interfaces refactor(graphql): add policy checking to GraphQL interfaces Jul 28, 2022
@aligo aligo linked an issue Jul 28, 2022 that may be closed by this pull request
@aligo aligo marked this pull request as ready for review July 28, 2022 09:51
@aligo aligo enabled auto-merge (squash) July 28, 2022 09:51
@aligo aligo merged commit 425e6b4 into main Jul 28, 2022
@aligo aligo deleted the graphql branch July 28, 2022 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

block/document related graphql mutations should have permission checking
2 participants