Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

feat(spreadsheet): migrate spreadsheet block view to ReactNodeViewRenderer #508

Merged
merged 3 commits into from
Aug 4, 2022

Conversation

aligo
Copy link
Contributor

@aligo aligo commented Aug 4, 2022

No description provided.

@aligo aligo changed the title Spreadsheet feat(spreadsheet): migrate spreadsheet block view to ReactNodeViewRenderer Aug 4, 2022
@aligo aligo linked an issue Aug 4, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #508 (3fd0aa2) into main (575aabb) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   69.26%   69.27%   +0.01%     
==========================================
  Files        1073     1073              
  Lines       18444    18444              
  Branches     2578     2578              
==========================================
+ Hits        12775    12777       +2     
+ Misses       5354     5353       -1     
+ Partials      315      314       -1     
Flag Coverage Δ
frontend-unit 65.03% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/editors/documentEditor/documentEditor.style.ts 100.00% <ø> (ø)
...nents/blockViews/Spreadsheet/SpreadsheetRender.tsx 50.00% <25.00%> (-4.17%) ⬇️
...ts/blockViews/Spreadsheet/SpreadsheetBlockView.tsx 33.08% <40.00%> (+0.99%) ⬆️
...ponents/blockViews/Spreadsheet/SpreadsheetView.tsx 12.50% <75.00%> (-1.20%) ⬇️
...onents/blockViews/Spreadsheet/Spreadsheet.style.ts 100.00% <100.00%> (ø)
...r/src/extensions/blocks/spreadsheet/spreadsheet.ts 95.83% <100.00%> (ø)
...legacy-editor/src/tiptapRefactor/ReactNodeView.tsx 14.96% <0.00%> (+1.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

This pull request has been built and is available for preview at pr508.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@aligo aligo marked this pull request as ready for review August 4, 2022 06:05
@aligo aligo enabled auto-merge (squash) August 4, 2022 06:06
@aligo aligo merged commit 43fde7c into main Aug 4, 2022
@aligo aligo deleted the spreadsheet branch August 4, 2022 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate SpreadsheetBlock from LegacyReactNodeViewRenderer
2 participants