Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

fix(client): fix select highlight pos and add sub page loading problem #509

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

melchior-voidwolf
Copy link
Contributor

@melchior-voidwolf melchior-voidwolf commented Aug 4, 2022

#460
#491

Disable the virtual mode of the Select by default
Select has a cursor because it supports search

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #509 (cf4869c) into main (575aabb) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   69.26%   69.26%           
=======================================
  Files        1073     1073           
  Lines       18444    18444           
  Branches     2578     2578           
=======================================
  Hits        12775    12775           
  Misses       5354     5354           
  Partials      315      315           
Flag Coverage Δ
frontend-unit 65.02% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../_shared/DocumentPageSidebar/PageTree/PageMenu.tsx 0.00% <0.00%> (ø)
...ages/design-system/src/components/Select/index.tsx 62.50% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

This pull request has been built and is available for preview at pr509.mashcard.dev.
Default username/password is test1@example.com & test1234.

Devtools

@stackia stackia merged commit c9e6194 into main Aug 4, 2022
@stackia stackia deleted the kailfix branch August 4, 2022 08:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants