Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid XML #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ralexander-phi
Copy link

Hey folks, awesome list!

I've also noticed issues with invalid XML in the OPML files. I've gone through each OPML file and manually fixed problems. I stripped extra quotes, converted & to &, stripped out HTML tags, and removed special characters like newlines.

I've validated the output using:

find . -name '*.opml' -print0 | xargs -0 -I '{}' xmllint --valid '{}' --noout 2>&1 | egrep -v "(no DTD)|(opml version)|(    \^)"

This ignores DTD error messages, which aren't technically validation problems.

I've also run the fix-up script in #2, which normalizes a couple minor things.

I've also noticed that many feed URLs are now returning errors. I'm considering replacing or removing those. Is this project interested in third party contributors, or would it be best for me to continue work in a fork?

Thanks for releasing this list!

I ran this command to validate XML:

    find . -name '*.opml' -print0 | xargs -0 -I '{}' xmllint --valid '{}' --noout 2>&1 | egrep -v "(no DTD)|(opml version)|(    \^)"

This ignores DTD messages, which aren't technically XML validation
errors.
@ralexander-phi
Copy link
Author

The cleanup script made many whitespace fixes, on GitHub you can ignore these by adding w=1 to the URL like: https://github.com/plenaryapp/awesome-rss-feeds/pull/13/files?w=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants