Proposed v0.6 API and structural changes #191
Comments
jimafisk
added
the
breaking
|
Applied the |
|
We should think about reworking pagination as well. No need to create a completely new content object for each pager. We could change the |
|
I'm planning on making the default pager value inside content objects const things = allContent.filter(content => content.type === "thing" && !content.pager);This is a breaking change, because if you were simply setting the current page like I've mentioned before: $: currentPage = content.pager;You now need to set the default page yourself: $: currentPage = content.pager ? content.pager : 1;I need this for a project I'm working on, so I might sneak it in before the |
|
The |
|
I've been working on this. The structural changes to the built app will be:
We probably want to move all compiled layouts into a
Should we hash / fingerprint the |
We currently hold built javascript assets in a folder called
spa, should we rename this folderlayoutsto better match the initial project files? Name conflicts with user defined routes / static HTML?Ejected files get put into a folder in the project root called
ejected, maybe a better name for this would becore. Would need to update the folder name for the built site as well.Currently we're performing EjectCopy separately from the Client build process where we prep ejected svelte files that need to get compiled. Seems redundant to walk these files twice, eject_copy should probably just be a func call during the Client build when non
.sveltefiles are found. This would speed up the build process.I placed the new
--minifyprocessing inside of Gopack for now. I didn't want to insert it before Gopack ran because it could screw up the regexp needed to update paths for ESM. Made me think the way we're running Gopack in general is redundant: we're re-reading files already written to the FS during the Client build, updating the content and re-writing them back to the filesystem. We could probably just do this when the files are still[]byteafter being compiled initially, before they are written to the filesystem. We could do the minification there as well. This would speed up the build process.The text was updated successfully, but these errors were encountered: