Skip to content

Commit

Permalink
major(deps): Upgrade to Guice v7 (#239)
Browse files Browse the repository at this point in the history
  • Loading branch information
erwinw committed Feb 2, 2024
1 parent a105b8c commit 30552c5
Show file tree
Hide file tree
Showing 19 changed files with 37 additions and 36 deletions.
4 changes: 2 additions & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ commonsBeanUtilsVersion = "1.9.4"
commonsConfiguration2Version = "2.8.0"
googleGuavaVersion = "31.1-jre"
googleTruthVersion = "1.1.3"
guiceVersion = "5.1.0"
guiceVersion = "7.0.0"
jacksonVersion = "2.14.2"
junitVersion = "5.9.3"
kotlinGuiceVersion = "1.6.0"
kotlinGuiceVersion = "3.0.0"
kotlinVersion = "1.8.0"
kotlinterGradleVersion = "3.16.0"
logbackClassicVersion = "1.4.5"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import io.pleo.prop.core.Prop
import javax.inject.Inject
import com.google.inject.name.Named as GoogleNamed
import javax.inject.Named as JavaxNamed
import jakarta.inject.Named as JakartaNamed

class BothNamedAnnotations
@Inject
constructor(
@JavaxNamed("io.pleo.test.prop3") val stringProp1: Prop<String>,
@JakartaNamed("io.pleo.test.prop3") val stringProp1: Prop<String>,
@GoogleNamed("io.pleo.test.prop4") val stringProp2: Prop<String>,
)
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.name.Named
import io.pleo.prop.core.Prop
import javax.inject.Inject
import javax.inject.Named

@Suppress("unused")
class ComplexObjects
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.name.Named
import io.pleo.prop.core.Prop
import javax.inject.Inject
import javax.inject.Named
import javax.money.CurrencyUnit

class CurrencyUnitProp
Expand Down
4 changes: 2 additions & 2 deletions prop-all/src/test/kotlin/io/pleo/prop/objects/DefaultValue.kt
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.name.Named
import io.pleo.prop.core.Default
import io.pleo.prop.core.Prop
import javax.inject.Inject
import javax.inject.Named

class DefaultValue
@Inject
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import io.pleo.prop.core.Prop
import javax.inject.Inject
import javax.inject.Named
import jakarta.inject.Named

@Suppress("UNUSED_PARAMETER")
class EmptyNamedAnnotation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ package io.pleo.prop.objects
import com.google.inject.AbstractModule
import com.google.inject.Provides
import com.google.inject.Singleton
import com.google.inject.name.Named
import io.pleo.prop.core.Prop
import javax.inject.Named

@Suppress("unused", "SpellCheckingInspection", "unused_parameter")
class InlineProviderModule : AbstractModule() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.name.Named
import io.pleo.prop.core.Default
import io.pleo.prop.core.Prop
import javax.inject.Inject
import javax.inject.Named

@Suppress("unused")
class InvalidDefaultValue
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.name.Named
import io.pleo.prop.core.Default
import io.pleo.prop.core.Prop
import javax.inject.Inject
import javax.inject.Named

@Suppress("unused")
class InvalidDefaultValueButValidValue
Expand Down
4 changes: 2 additions & 2 deletions prop-all/src/test/kotlin/io/pleo/prop/objects/InvalidJSON.kt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.name.Named
import io.pleo.prop.core.Prop
import javax.inject.Inject
import javax.inject.Named

@Suppress("UNUSED_PARAMETER")
class InvalidJSON
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.assistedinject.Assisted
import com.google.inject.name.Named
import io.pleo.prop.core.Prop
import javax.inject.Named

@Suppress("unused")
class MyAssistedInjectFactoryImp
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.assistedinject.Assisted
import com.google.inject.name.Named
import io.pleo.prop.core.Prop
import javax.inject.Named

@Suppress("unused")
class MyAssistedInjectFactoryImp2
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.name.Named
import io.pleo.prop.core.Prop
import javax.inject.Inject
import javax.inject.Named
import javax.inject.Provider
import jakarta.inject.Provider

class MyInterfaceProvider
@Inject
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package io.pleo.prop.objects

import javax.inject.Inject
import com.google.inject.Inject
import javax.sql.DataSource

class NoPropObject
Expand Down
4 changes: 2 additions & 2 deletions prop-all/src/test/kotlin/io/pleo/prop/objects/NullValue.kt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.name.Named
import io.pleo.prop.core.Prop
import javax.inject.Inject
import javax.inject.Named

@Suppress("unused", "UNUSED_PARAMETER")
class NullValue
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.name.Named
import io.pleo.prop.core.Prop
import javax.inject.Inject
import javax.inject.Named

class SamePropertyAsComplexObjects
@Inject
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import io.pleo.prop.core.Prop
import javax.inject.Inject

@Suppress("unused", "UNUSED_PARAMETER")
class UnnamedProp
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package io.pleo.prop.objects

import com.google.inject.Inject
import com.google.inject.name.Named
import io.pleo.prop.core.Prop
import javax.inject.Inject
import javax.inject.Named

class UsesTwiceSameProp
@Inject
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ import java.lang.reflect.ParameterizedType
import java.lang.reflect.Type
import java.util.Optional.ofNullable
import java.util.function.Predicate
import javax.inject.Named
import com.google.inject.name.Named as GoogleNamed
import jakarta.inject.Named as JakartaNamed

typealias PropResult = Result<Prop<*>>

Expand Down Expand Up @@ -134,8 +135,8 @@ class PropMappingVisitor(

private fun annotationValueIfNamed(annotation: Annotation): String? =
when (annotation) {
is Named -> annotation.value
is com.google.inject.name.Named -> annotation.value
is JakartaNamed -> annotation.value
is GoogleNamed -> annotation.value
else -> null
}?.ifEmpty { null }
}

0 comments on commit 30552c5

Please sign in to comment.